From 97dea4eda39c28306b3f3685a6165aef78ae8e38 Mon Sep 17 00:00:00 2001 From: Christian Schneider Date: Thu, 2 May 2024 17:37:18 +0200 Subject: Do not check body_on_fail with assoc mode, we looked at those separately --- it_url.class | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/it_url.class b/it_url.class index e6e0ddf..c122aeb 100644 --- a/it_url.class +++ b/it_url.class @@ -361,7 +361,7 @@ function request($p=array()) else { # FIXME 2024-06 CS Send a notice in cases where changing the default to body_on_fail=false would change result for text results - if ($url->result >= 400 && $url->data && !isset($p['body_on_fail']) && it::match('^text/', $url->headers['Content-Type'])) + if ($url->result >= 400 && $url->data && !$p['assoc'] && !isset($p['body_on_fail']) && it::match('^text/', $url->headers['Content-Type'])) it::error(['to' => 'schneider@search.ch', 'title' => 'Failing it_url::get() without body_on_fail but non-empty data', 'body' => ['p' => $p, 'url' => $url]]); if ($url->result >= 400 && ((isset($p['body_on_fail']) && !$p['body_on_fail']) || $p['empty_on_fail'] || $p['keepfailed'])) # FIXME 2024-06 CS Remove deprecated empty_on_fail support -- cgit v1.2.3