From 3538e258590fda78b697ef0e8280585f818034e4 Mon Sep 17 00:00:00 2001
From: Urban Müller
Date: Tue, 4 Aug 2020 17:55:30 +0200
Subject: correctly retry in ::get_multi, do retry in status 5xx in ::get

---
 test/it_url.t              | 21 +++++++++++++++++++++
 test/it_url.testserver.php |  8 +++++++-
 2 files changed, 28 insertions(+), 1 deletion(-)

(limited to 'test')

diff --git a/test/it_url.t b/test/it_url.t
index 5bac758..1636bd6 100755
--- a/test/it_url.t
+++ b/test/it_url.t
@@ -316,6 +316,27 @@ ok(strpos($pages['a'], '</html>'), 'it_url::get_multi got first url'); # UTF8SAF
 ok(strpos($pages['b'], '</html>'), 'it_url::get_multi got second url'); # UTF8SAFE
 is(count($pages), 2, 'it_url::get_multi no additional array elements');
 
+handle_server(
+	is(
+		it_url::get('http://localhost:8000/maybe_error?chance=0'),
+		"success"
+	),
+	is(
+		it_url::get('http://localhost:8000/maybe_error?chance=100'),
+		"failure"
+	),
+	is(
+		it_url::get('url' => 'http://localhost:8000/maybe_error?chance=10', 'retries' => 10),
+		"success",
+		"Retry on sporadically failing url in ::get"
+	),
+	is(
+		it_url::get_multi('urls' => ['http://localhost:8000/maybe_error?chance=10'], 'retries' => 10),
+		["success"],
+		"Retry on sporadically failing url in ::get_multi"
+	),
+);
+
 is(it_url::parse("/foo"), ["/foo"], "it_url::parse path only");
 is(it_url::parse("/foo?"), ["/foo"], "it_url::parse empty parameter");
 is(it_url::parse("/foo?bar=baz&qux=quux"), ["/foo", 'bar' => "baz", 'qux' => "quux"], "it_url::parse parameters");
diff --git a/test/it_url.testserver.php b/test/it_url.testserver.php
index 64e6674..f895d61 100644
--- a/test/it_url.testserver.php
+++ b/test/it_url.testserver.php
@@ -1,5 +1,5 @@
 <?php
-$stderr = fopen('php://stderr', 'w');
+$stderr = it::fopen('php://stderr', 'w');
 fwrite($stderr, "Got Request: '" . $_SERVER['REQUEST_URI'] . "'\n");
 $base = 'http://' . $_SERVER['HTTP_HOST'];
 
@@ -69,6 +69,12 @@ switch ($_SERVER['PHP_SELF'])
 		http_response_code(204);
 		break;
 
+	case "/maybe_error":
+		$iserror = rand(0, 99) <= $_REQUEST['chance'];
+		http_response_code($iserror ? 500 : 200);
+		echo $iserror ? "failure" : "success";
+		break;
+
 	default:
 		http_response_code(404);
 		fwrite($stderr, "Unknown path '$_SERVER[PHP_SELF]' not handled!\n");
-- 
cgit v1.2.3